Artwork

Content provided by The Ruby Rogues. All podcast content including episodes, graphics, and podcast descriptions are uploaded and provided directly by The Ruby Rogues or their podcast platform partner. If you believe someone is using your copyrighted work without your permission, you can follow the process outlined here https://player.fm/legal.
Player FM - Podcast App
Go offline with the Player FM app!

216 RR Code Review Culture with Derek Prior

1:05:37
 
Share
 

Archived series ("HTTP Redirect" status)

Replaced by: devchat.tv

When? This feed was archived on May 03, 2016 04:22 (8y ago). Last successful fetch was on May 02, 2016 00:47 (8y ago)

Why? HTTP Redirect status. The feed permanently redirected to another series.

What now? If you were subscribed to this series when it was replaced, you will now be subscribed to the replacement series. This series will no longer be checked for updates. If you believe this to be in error, please check if the publisher's feed link below is valid and contact support to request the feed be restored or if you have any other concerns about this.

Manage episode 91916074 series 19332
Content provided by The Ruby Rogues. All podcast content including episodes, graphics, and podcast descriptions are uploaded and provided directly by The Ruby Rogues or their podcast platform partner. If you believe someone is using your copyrighted work without your permission, you can follow the process outlined here https://player.fm/legal.

03:42 - Derek Prior Introduction

04:01 - Code Reviews

05:14 - What happens when you don’t do code reviews?

06:30 - Not Emphasizing Code Quality, Setting Code Review Up for Failure

  • Edge Cases
  • Diverse Feedback, Team Conflict

10:43 - Code Reviewing Yourself: Answering Your Own Questions

12:03 - The Evolution of Code Review (Code Review as an Asynchronous Process)

14:51 - Small Changes, “Pull Request Bombs”

23:49 - Making Code Review a Supportive Process

  • Stop Issuing Commands; Ask Probing Questions
  • DON’T Use “Why didn’t you ________?”
  • DO Use “Have you considered _________?”
  • or “That’s interesting…I might have used _______.”

30:32 - What qualities should reviewees have?

34:27 - Getting Code Reviews Introduced Into Company Culture

38:30 - Making Sure Code Reviews Get Done

40:47 - Tagging Specific Team Members

  • LGTM = Looks Good To Me
  • Gerrit

44:39 - Other Handy Code Review Tools

47:49 - Code Review Feedback Resources for Solo Programmers

Picks

Code Newbie Podcast: Sandi Metz Part I (Saron)
Code Newbie Podcast: Sandi Metz Part II (Saron)
If Google Were A Guy (Saron)
LEGO Ideas - Lovelace & Babbage (Coraline)
CoverMyMeds is offering Ruby on Rails training for experienced developers (David)
CoverMyMeds Billboard 1 (David)
CoverMyMeds Billboard 2 (David)
The Bike Shed Podcast (Derek)
The Ember RFC Process (Derek)
tota11y (Derek)
Eileen Uchitelle: How to Performance @ GoRuCo 2015 (Derek)
Olympus SP-100EE (Avdi)

  continue reading

258 episodes

Artwork
iconShare
 

Archived series ("HTTP Redirect" status)

Replaced by: devchat.tv

When? This feed was archived on May 03, 2016 04:22 (8y ago). Last successful fetch was on May 02, 2016 00:47 (8y ago)

Why? HTTP Redirect status. The feed permanently redirected to another series.

What now? If you were subscribed to this series when it was replaced, you will now be subscribed to the replacement series. This series will no longer be checked for updates. If you believe this to be in error, please check if the publisher's feed link below is valid and contact support to request the feed be restored or if you have any other concerns about this.

Manage episode 91916074 series 19332
Content provided by The Ruby Rogues. All podcast content including episodes, graphics, and podcast descriptions are uploaded and provided directly by The Ruby Rogues or their podcast platform partner. If you believe someone is using your copyrighted work without your permission, you can follow the process outlined here https://player.fm/legal.

03:42 - Derek Prior Introduction

04:01 - Code Reviews

05:14 - What happens when you don’t do code reviews?

06:30 - Not Emphasizing Code Quality, Setting Code Review Up for Failure

  • Edge Cases
  • Diverse Feedback, Team Conflict

10:43 - Code Reviewing Yourself: Answering Your Own Questions

12:03 - The Evolution of Code Review (Code Review as an Asynchronous Process)

14:51 - Small Changes, “Pull Request Bombs”

23:49 - Making Code Review a Supportive Process

  • Stop Issuing Commands; Ask Probing Questions
  • DON’T Use “Why didn’t you ________?”
  • DO Use “Have you considered _________?”
  • or “That’s interesting…I might have used _______.”

30:32 - What qualities should reviewees have?

34:27 - Getting Code Reviews Introduced Into Company Culture

38:30 - Making Sure Code Reviews Get Done

40:47 - Tagging Specific Team Members

  • LGTM = Looks Good To Me
  • Gerrit

44:39 - Other Handy Code Review Tools

47:49 - Code Review Feedback Resources for Solo Programmers

Picks

Code Newbie Podcast: Sandi Metz Part I (Saron)
Code Newbie Podcast: Sandi Metz Part II (Saron)
If Google Were A Guy (Saron)
LEGO Ideas - Lovelace & Babbage (Coraline)
CoverMyMeds is offering Ruby on Rails training for experienced developers (David)
CoverMyMeds Billboard 1 (David)
CoverMyMeds Billboard 2 (David)
The Bike Shed Podcast (Derek)
The Ember RFC Process (Derek)
tota11y (Derek)
Eileen Uchitelle: How to Performance @ GoRuCo 2015 (Derek)
Olympus SP-100EE (Avdi)

  continue reading

258 episodes

All episodes

×
 
Loading …

Welcome to Player FM!

Player FM is scanning the web for high-quality podcasts for you to enjoy right now. It's the best podcast app and works on Android, iPhone, and the web. Signup to sync subscriptions across devices.

 

Quick Reference Guide